-
Notifications
You must be signed in to change notification settings - Fork 49
Add CONTRIBUTING.md #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add CONTRIBUTING.md #1371
Conversation
Benchmark results Main vs HEAD.Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
|
Benchmarking resultsBenchmark for program
|
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.658 ± 0.049 | 10.590 | 10.775 | 4.32 ± 0.05 |
cairo-native (embedded AOT) |
2.465 ± 0.026 | 2.435 | 2.526 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.554 ± 0.016 | 2.521 | 2.571 | 1.04 ± 0.01 |
Benchmark for program dict_snapshot
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
535.1 ± 7.2 | 520.3 | 544.1 | 1.00 |
cairo-native (embedded AOT) |
2168.9 ± 29.3 | 2128.5 | 2208.5 | 4.05 ± 0.08 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2289.5 ± 28.9 | 2254.4 | 2336.4 | 4.28 ± 0.08 |
Benchmark for program factorial_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.763 ± 0.016 | 4.739 | 4.787 | 1.84 ± 0.02 |
cairo-native (embedded AOT) |
2.595 ± 0.025 | 2.552 | 2.635 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.627 ± 0.016 | 2.599 | 2.658 | 1.01 ± 0.01 |
Benchmark for program fib_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.694 ± 0.010 | 4.681 | 4.718 | 2.20 ± 0.04 |
cairo-native (embedded AOT) |
2.133 ± 0.034 | 2.096 | 2.193 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.154 ± 0.021 | 2.133 | 2.200 | 1.01 ± 0.02 |
Benchmark for program linear_search
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
590.0 ± 7.5 | 577.2 | 603.3 | 1.00 |
cairo-native (embedded AOT) |
2231.7 ± 43.7 | 2179.0 | 2311.3 | 3.78 ± 0.09 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2364.1 ± 17.2 | 2327.6 | 2393.8 | 4.01 ± 0.06 |
Benchmark for program logistic_map
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
387.4 ± 4.9 | 379.1 | 393.1 | 1.00 |
cairo-native (embedded AOT) |
2312.4 ± 27.8 | 2269.9 | 2355.0 | 5.97 ± 0.10 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2470.4 ± 34.2 | 2423.4 | 2528.1 | 6.38 ± 0.12 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1371 +/- ##
=======================================
Coverage 76.22% 76.22%
=======================================
Files 111 111
Lines 26520 26520
=======================================
Hits 20214 20214
Misses 6306 6306 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DiegoCivi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention that commits need to be verified/signed?
|
|
||
| #### How Do I Submit a Good Bug Report? | ||
|
|
||
| <!-- > You must never report security related issues, vulnerabilities or bugs including sensitive information to the issue tracker, or elsewhere in public. Instead sensitive bugs must be sent by email to <>. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a mail or maybe remove this part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this section is not seen in the .md and can be completed in the future. You can dismiss this comment
Adds CONTRIBUTING.md to the project.
Based of https://contributing.md/generator/
The first commits adds the generated file, and the second commit changes a few thing to better suit our needs. You can review the second commit here: 093b323.