Skip to content

Conversation

@DiegoCivi
Copy link
Contributor

Fix BoundedInt is_zero libfunc

When using bounded_int_is_zero() libfunc with bounded ints that had a lower bound different than 0, we were not taking into account the offset used so it was not working properly.

Closes #NA

Introduces Breaking Changes?

Yes/No.

These PRs should be merged after this one right away, in that order.

Checklist

  • Linked to Github Issue.
  • Unit tests added.
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@DiegoCivi DiegoCivi changed the title Fix BoundedInt is_zero libfunc [0.6.x] Fix BoundedInt is_zero libfunc Nov 14, 2025
@DiegoCivi DiegoCivi marked this pull request as ready for review November 14, 2025 21:51
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.52%. Comparing base (7627108) to head (6cbd14c).
⚠️ Report is 2 commits behind head on v0.6.

Files with missing lines Patch % Lines
src/libfuncs/bounded_int.rs 85.71% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             v0.6    #1467      +/-   ##
==========================================
+ Coverage   76.22%   76.52%   +0.30%     
==========================================
  Files         111      111              
  Lines       26531    26558      +27     
==========================================
+ Hits        20223    20324     +101     
+ Misses       6308     6234      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants