Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEVM: get_state_transitions for the ef-tests #2021

Open
fborello-lambda opened this issue Feb 20, 2025 · 0 comments
Open

LEVM: get_state_transitions for the ef-tests #2021

fborello-lambda opened this issue Feb 20, 2025 · 0 comments
Labels
levm Lambda EVM implementation

Comments

@fborello-lambda
Copy link
Contributor

We had the get_state_transitions function triplicated. With #1949 we centralize the code in one function. However, there is a problem when we use the function when running the ef-tests, a specific computation is performed depending on the fork (line).

If we get the fork from the block's timestamp:

let block_header = current_db
    .get_block_header_by_hash(block_hash)?
    .ok_or(StoreError::MissingStore)?;
let fork_from_config = initial_state.chain_config()?.fork(block_header.timestamp);

it differs from the fork passed as variable in the ef-tests' runners.

I've added an Option<Fork> as function argument: ef_tests: Option<Fork>. It works for now, but we should find a better way and why the fork differs. May have something to do with the genesis used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
levm Lambda EVM implementation
Projects
Status: No status
Development

No branches or pull requests

1 participant