Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): change ethereum_rust to ethrex in code #1215

Merged
merged 7 commits into from
Nov 20, 2024
Merged

chore(core): change ethereum_rust to ethrex in code #1215

merged 7 commits into from
Nov 20, 2024

Conversation

jrchatruc
Copy link
Collaborator

Motivation

Description

@jrchatruc jrchatruc requested a review from a team as a code owner November 20, 2024 12:54
@jrchatruc jrchatruc changed the title Change ethereum_rust to ethrex in code chore(core): change ethereum_rust to ethrex in code Nov 20, 2024
@ElFantasma
Copy link
Contributor

ElFantasma commented Nov 20, 2024 •
edited
Loading

There are still some mentions to ethereum-rust (with a hyphen instead of an underscore) that maybe we should change: Some file names, and the branch from our fork for ethereum-package repository.
Other than that it looks good

ElFantasma
ElFantasma approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@ElFantasma ElFantasma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a small comment

@jrchatruc
Copy link
Collaborator Author

There are still some mentions to ethereum-rust (with a hyphen instead of an underscore) that maybe we should change: Some of file names, and the branch from our fork for ethereum-package repository. Other than that it looks good

Fixed the ethereum-rust instances along with some ethereumrust ones here d0d8b05

@jrchatruc jrchatruc added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit aefb130 Nov 20, 2024
25 checks passed
@jrchatruc jrchatruc deleted the ethrex-change-in-code branch November 20, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElFantasma ElFantasma ElFantasma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrchatruc @ElFantasma