feat(levm): cache refactor #1314

ilitteri · 2024-11-27T16:48:31Z

Motivation

Description

A set touched_accounts is introduced to track read accounts.
Cache is no longer used as a tracker of read accounts. It is now only used to track updated accounts. All the account update logic is encapsulated in individual functions.
Cache struct is removed and a cache module is introduced with the cache's behavior.
Gas cost functions where the access cost takes place were refactored.

Leftovers

L1, LEVM: FIlter non-updated account from cache #1316

EF Test Report

8 more tests pass without any further changes

✓ Ethereum Foundation Tests: 714 passed 3387 failed 4101 total run - 12:08
✓ Summary: 714/4101

Cancun: 627/3578
Shanghai: 33/221
Homestead: 0/17
Istanbul: 0/34
London: 17/39
Byzantium: 0/33
Berlin: 17/35
Constantinople: 0/66
Merge: 20/62
Frontier: 0/16

Now we have a levm_runner in charge of running the whole suite of tests (or the chosen ones) and then a revm_runner that re-runs the tests that levm failed to run successfully

This reverts commit 1391e03.

…to fix_ef_test_parsing

…uting gas costs

…to refactor_levm_new_state

maximopalopoli

LGTM, I just leave you some comments

crates/vm/levm/src/vm.rs

maximopalopoli · 2024-11-27T19:57:46Z

crates/vm/levm/src/gas_cost.rs

+    Ok(static_gas
+        .checked_add(dynamic_gas)
+        .ok_or(OutOfGasError::GasCostOverflow)?)
+}


Maybe the call type opcodes can be abstracted to a call_type_cost, or similar

crates/vm/levm/src/vm.rs

…to refactor_levm_new_state

crates/vm/levm/src/gas_cost.rs

crates/vm/levm/src/vm.rs

…to refactor_levm_new_state

ilitteri and others added 30 commits November 19, 2024 12:45

Do not skip VMTests

4de7a5e

Refactor runner

33b948f

Now we have a levm_runner in charge of running the whole suite of tests (or the chosen ones) and then a revm_runner that re-runs the tests that levm failed to run successfully

Isolate EF test parsing

950f2aa

Fix initial state loading

9eaab48

Fix types

cdc76d4

Fix deserialization

e389c73

Refactor report module

a28aa00

Rename test file and modules

f72bd3f

Ignore report file

798ca19

Chore

0df3e41

Merge main

1391e03

Revert "Merge main"

3e7ece3

This reverts commit 1391e03.

Merge branch 'main' of github.com:lambdaclass/lambda_ethereum_rust in…

50cf7af

…to fix_ef_test_parsing

Update cmd/ef_tests/levm/runner/levm_runner.rs

221990c

Fix

a437508

Fix parsing

12333c1

Fix parsing

0e51cf8

We do not need a mutable reference to the current call frame for comp…

3171a94

…uting gas costs

Refactor op_balance

1985654

Refactor op_extcodesize

b94ad31

Refactor op_extcodehash

e56ee1c

Refactor op_extcodecopy

553e998

Refactor op_call

722c8e3

Leftovers

7d9b957

Refactor op_callcode

f574d87

Add memory expansion cost functions

8a1785d

Refactor op_delegatecall

cce5db9

Refactor op_delegatecall leftovers

c0a71c3

Refactor op_staticcall

f9dded0

Refactor transaction validation

6af6ce3

ilitteri self-assigned this Nov 27, 2024

ilitteri requested a review from a team as a code owner November 27, 2024 16:48

ilitteri and others added 7 commits November 27, 2024 13:49

Fix compilation

1073d38

Fix extcodecopy

aeaaf59

Merge branch 'main' into refactor_levm_new_state

87e0de6

Merge branch 'main' of github.com:lambdaclass/lambda_ethereum_rust in…

781aa0b

…to refactor_levm_new_state

remove leftover dbg

fd23ff2

Add todo

9cf371e

Remove comment

fc469b8

maximopalopoli approved these changes Nov 27, 2024

View reviewed changes

ilitteri commented Nov 27, 2024

View reviewed changes

crates/vm/levm/src/vm.rs Outdated Show resolved Hide resolved

Update crates/vm/levm/src/vm.rs

729e035

ilitteri commented Nov 27, 2024

View reviewed changes

crates/vm/levm/src/vm.rs Outdated Show resolved Hide resolved

ilitteri and others added 4 commits November 27, 2024 17:52

Fix touched_storage_slots

a3382c7

Caller, callee, and coinbase are warm by default

f580d6c

Merge branch 'main' into refactor_levm_new_state

f725ec7

Merge branch 'main' of github.com:lambdaclass/lambda_ethereum_rust in…

d335af3

…to refactor_levm_new_state

ilitteri enabled auto-merge November 28, 2024 13:49

Merge branch 'main' into refactor_levm_new_state

647f5aa

jrchatruc reviewed Nov 28, 2024

View reviewed changes

crates/vm/levm/src/gas_cost.rs Outdated Show resolved Hide resolved

jrchatruc reviewed Nov 28, 2024

View reviewed changes

crates/vm/levm/src/vm.rs Outdated Show resolved Hide resolved

ilitteri added 4 commits November 28, 2024 13:15

Merge branch 'main' of github.com:lambdaclass/lambda_ethereum_rust in…

765f5ee

…to refactor_levm_new_state

Remove commented code

c83a496

Add constants for SSTORE

0835db6

Leftover

d78436a

jrchatruc approved these changes Nov 28, 2024

View reviewed changes

ilitteri added this pull request to the merge queue Nov 28, 2024

Merged via the queue into main with commit f496c7c Nov 28, 2024
15 checks passed

ilitteri deleted the refactor_levm_new_state branch November 28, 2024 16:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(levm): cache refactor #1314

feat(levm): cache refactor #1314

ilitteri commented Nov 27, 2024 •

edited

Loading

maximopalopoli left a comment

maximopalopoli Nov 27, 2024

feat(levm): cache refactor #1314

feat(levm): cache refactor #1314

Conversation

ilitteri commented Nov 27, 2024 • edited Loading

maximopalopoli left a comment

Choose a reason for hiding this comment

maximopalopoli Nov 27, 2024

Choose a reason for hiding this comment

ilitteri commented Nov 27, 2024 •

edited

Loading