Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(levm): logx non-compliance memory allocation #1330

Merged
merged 3 commits into from
Nov 28, 2024
Merged

fix(levm): logx non-compliance memory allocation #1330

merged 3 commits into from
Nov 28, 2024

Conversation

ilitteri
Copy link
Contributor

Resolves #1323

@ilitteri ilitteri added the levm Lambda EVM implementation label Nov 28, 2024
@ilitteri ilitteri self-assigned this Nov 28, 2024
@ilitteri ilitteri requested a review from a team as a code owner November 28, 2024 13:33
JereSalo
JereSalo approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@JereSalo JereSalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This error is pretty similar to the one in which we try to calculate memory expansion cost when size is 0

@ilitteri ilitteri enabled auto-merge November 28, 2024 17:12
@ilitteri ilitteri added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 0941ec3 Nov 28, 2024
15 checks passed
@ilitteri ilitteri deleted the fix_logx_non_compliance branch November 28, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JereSalo JereSalo JereSalo approved these changes

Assignees

@ilitteri ilitteri

Labels
levm Lambda EVM implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SECURITY] Non-Compliance : Unnecessary Memory Allocation in LOGX Opcode Implementation
2 participants
@ilitteri @JereSalo