feat(core): batch heavy write operations #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrchatruc
force-pushed
the
batch-heavy-write-operations
branch
from
c310f7f to
67590b7
Compare
jrchatruc
force-pushed
the
batch-heavy-write-operations
branch
from
67590b7 to
4dec142
Compare
fkrause98
reviewed
Dec 4, 2024
| @@ -14,4 +14,6 @@ use crate::error::TrieError; | |||
| pub trait TrieDB { | |||
| fn get(&self, key: Vec<u8>) -> Result<Option<Vec<u8>>, TrieError>; | |||
| fn put(&self, key: Vec<u8>, value: Vec<u8>) -> Result<(), TrieError>; | |||
| // fn put_batch(&self, key: Vec<u8>, value: Vec<u8>) -> Result<(), TrieError>; | |||
fkrause98
reviewed
Dec 4, 2024
crates/storage/trie/db/in_memory.rs
Outdated
| @@ -25,4 +25,14 @@ impl TrieDB for InMemoryTrieDB { | |||
| self.inner.lock().unwrap().insert(key, value); | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn put_batch(&self, key_values: Vec<(Vec<u8>, Vec<u8>)>) -> Result<(), TrieError> { | |||
| let mut db = self.inner.lock().unwrap(); | |||
There was a problem hiding this comment.
Don't unwrap here, let's return an error.
There was a problem hiding this comment.
Removed unwraps here 4845ce8
fkrause98
approved these changes
Dec 4, 2024
fkrause98
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR batches the three current heaviest db write operations on the node (
add_block,store_receipts, andcommit_node) so that a single db transaction is used for them. This reduces the time spent flushing to disc withmsync(onlibmdbx) orfsync(onredb) from around ~40-50% to ~0.35%.Non-batched version:
Batched version (the
msyncon this flamegraph is one of the tiny red bars to the left):Description