Skip to content

feat: implement ENRRequestMessage encoding #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 11, 2024
Merged

feat: implement ENRRequestMessage encoding #137

merged 13 commits into from
Jul 11, 2024

Conversation

@ricomateo
Copy link
Contributor

@ricomateo ricomateo commented Jul 10, 2024 •
edited
Loading

This PR depends on #132, #136

Motivation
Implement discv4 protocol

Description
Enables ENRRequestMessage encoding

Closes #88

@ricomateo ricomateo marked this pull request as ready for review July 10, 2024 21:12
@ricomateo ricomateo requested a review from a team as a code owner July 10, 2024 21:12
@ricomateo ricomateo mentioned this pull request Jul 11, 2024
Merged
MegaRedHand
MegaRedHand approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricomateo ricomateo merged commit 6e0c299 into main Jul 11, 2024
@ricomateo ricomateo deleted the enr-request-encoding branch July 11, 2024 21:18
ricomateo added a commit that referenced this pull request Jul 16, 2024
@ricomateo
feat: implement ENRResponse decoding (#141)
aba1d91 
This PR depends on #137

**Motivation**
Implement discv4 protocol.

**Description**
Enables `ENRResponse` decoding

Closes #89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement ENRRequest message encoding

3 participants

@ricomateo @MegaRedHand