Skip to content

feat: implement ENRResponse encoding #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Jul 16, 2024
Merged

feat: implement ENRResponse encoding #144

merged 31 commits into from
Jul 16, 2024

Conversation

@ricomateo
Copy link
Contributor

@ricomateo ricomateo commented Jul 11, 2024 •
edited
Loading

This PR depends on #141

Motivation
Implement discv4 protocol

Description
Enables ENRResponse encoding

Closes #90

ricomateo added 29 commits July 10, 2024 12:18
@ricomateo
store peer data in buckets
dbe84f6
@ricomateo
add TODO comment
1773ba9
@ricomateo
add getters for Node fields
13c8063
@ricomateo
change Node fields back to private
03c2db6
@ricomateo
add getter for NeighborsMessage nodes field
7553afa
@ricomateo
remove unnecessary getters
426c852
@ricomateo
add KademliaTable to hold buckets and peer data
08bf1e8
@ricomateo
add PeerData and move table.rs out of types directory (and rename it …
d58a3d8 
…to kademlia.rs)
@ricomateo
move bootnode.rs out of types directory and delete types
9fbc5c6
@ricomateo
add ENRRequestMessage decoding
3508e70
@ricomateo
Merge branch 'store-peer-data' into enr-request-decoding
c12004c
@ricomateo
add ENRRequestMessage encoding
5ea9dee
@ricomateo
add ENRResponse decoding (without optional fields)
cc95747
@ricomateo
merge enr-request-encoding
160a11e
@ricomateo
add optional fields decoding
8277320
@ricomateo
rename ENRResponseContent to NodeRecord
36877db
@ricomateo
rename and add documentation to the decode_node_record_optional_field…
bbb8485 
…s function
@ricomateo
small fix
9558308
@ricomateo
add ENRResponseMessage encoding (not working)
d3c7f45
@ricomateo
refactor: optional key value pairs encoding
ed40380
@ricomateo
refactor: change NodeRecord to hold the optional fields in a vector o…
8c2ea13 
…f (key, value)
@ricomateo
small fixes
ee4f8aa
@ricomateo
add some documentation
057b3de
@ricomateo
merge main
02f7c04
@ricomateo
rename function and add some more documentation
8737f96
@ricomateo
add 'id' as a required field
f5ce81b
@ricomateo
fix linter
7aeee0e
@ricomateo
merge enr-response-decoding
534dc2d
@ricomateo
refactor encoding so it stores optional fields as key, value pairs
cf1ccd6
@ricomateo ricomateo marked this pull request as ready for review July 15, 2024 15:28
@ricomateo ricomateo requested a review from a team as a code owner July 15, 2024 15:28
ElFantasma
ElFantasma approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@ElFantasma ElFantasma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricomateo ricomateo merged commit 486fecf into main Jul 16, 2024
@ricomateo ricomateo deleted the enr-response-encoding branch July 16, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ElFantasma ElFantasma ElFantasma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement ENRResponse message encoding

3 participants

@ricomateo @ElFantasma