feat(l1): pooled transactions #1444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpaulucci
reviewed
Dec 12, 2024
| LegacyTransaction(LegacyTransaction), | ||
| EIP2930Transaction(EIP2930Transaction), | ||
| EIP1559Transaction(EIP1559Transaction), | ||
| WrappedEIP4844Transaction(WrappedEIP4844Transaction), |
There was a problem hiding this comment.
maybe EIP4844TransactionWithBlobs would be clearer?
fmoletta
reviewed
Dec 18, 2024
| /// The same as a Transaction enum, only that blob transactions are in wrapped format, including | ||
| /// the blobs bundle. | ||
| #[derive(Clone, Debug, PartialEq, Eq)] | ||
| pub enum P2PTransaction { |
There was a problem hiding this comment.
If this is a structure specifically made to fit the format expected by p2p can we move it there? Placing it in the same module as core types can lead to mix ups in the future
fmoletta
reviewed
Dec 18, 2024
| @@ -390,6 +390,14 @@ impl<S: AsyncWrite + AsyncRead + std::marker::Unpin> RLPxConnection<S> { | |||
| let request = GetPooledTransactions::new(random(), hashes); | |||
| self.send(Message::GetPooledTransactions(request)).await?; | |||
| } | |||
| // TODO: Also add handler for get pooled transactions. | |||
fmoletta
reviewed
Dec 18, 2024
| .flatten() | ||
| .collect(); | ||
|
|
||
| // TODO: add getting of the blob bundle, as we'll implement this as a p2p transaction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handling for:
Closes #385
Closes #384