Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(levm): fix transfer value in call, organize call opcodes and other fixes #1492

Merged
merged 15 commits into from
Dec 16, 2024
Merged

fix(levm): fix transfer value in call, organize call opcodes and other fixes #1492

merged 15 commits into from
Dec 16, 2024

Conversation

JereSalo
Copy link
Contributor

@JereSalo JereSalo commented Dec 12, 2024 •
edited
Loading

Motivation

Description

  • Removes in generic_call double definition of should_transfer_value

  • Organizes call opcodes

  • Now we don't return early when bytecode is empty. This was inaccurate behavior

Closes #issue_number

@JereSalo JereSalo added the levm Lambda EVM implementation label Dec 12, 2024
@JereSalo JereSalo self-assigned this Dec 12, 2024
@JereSalo JereSalo changed the title fix(levm): fix transfer value in call fix(levm): fix transfer value in call, organize call opcodes and other fixes Dec 12, 2024
@JereSalo JereSalo marked this pull request as ready for review December 13, 2024 15:45
@JereSalo JereSalo requested a review from a team as a code owner December 13, 2024 15:45
maximopalopoli
maximopalopoli approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@maximopalopoli maximopalopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Now you can also move generic_call to system.rs, as you said before.

LeanSerra
LeanSerra approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@LeanSerra LeanSerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a small comment

crates/vm/levm/src/opcode_handlers/system.rs Outdated Show resolved Hide resolved
@JereSalo JereSalo added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit d38ee81 Dec 16, 2024
4 checks passed
@JereSalo JereSalo deleted the levm/fix_transfer_value branch December 16, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximopalopoli maximopalopoli maximopalopoli approved these changes

@ilitteri ilitteri ilitteri approved these changes

@LeanSerra LeanSerra LeanSerra approved these changes

Assignees

@JereSalo JereSalo

Labels
levm Lambda EVM implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JereSalo @LeanSerra @ilitteri @maximopalopoli