-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add metrics/observability with prometheus #1518
Conversation
…ex into core/prometheus_grafana
|
||
prometheus = "0.13.4" | ||
|
||
# TODO: remove? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should we do about this TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left that TODO in case we want an api made by ourselves, do you think we can remove the comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not removed, but updated with this context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a comment and a suggestion. We can merge after resolving those.
Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com>
I have to change it back to
|
Motivation
We need a starting point to create dashboards with Grafana. Metrics are essential to observe the behavior of the node.
Description
Simple dashboard with a counter. Counts the transactions.
/metrics
endpoint → using axum for fast development, we may want to create a simple API from scratch without any crate.To test it out:
cd crates/l2 && cp .env.example .env
make rm-db-l2 && make init
cd crates/l2 && make cli
ethrex_l2 test load --path <full_path>/ethrex/test_data/private_keys.txt -i 1
admin
/admin
Ethrex - Transactions
dashboard, the dashboard should show172
. The previous cli's command sent 172 transactions.Example output:
Closes #1429