fix(l1): don't return an error if forkChoiceUpdate contains null PayloadAttributes
#1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
changed the title
forkChoiceUpdate contains null PayloadAttributes
mpaulucci
approved these changes
Dec 19, 2024
mpaulucci
reviewed
Dec 19, 2024
| match serde_json::from_value::<PayloadAttributesV3>(params[1].clone()) { | ||
| Ok(attributes) => Some(attributes), | ||
| match serde_json::from_value::<Option<PayloadAttributesV3>>(params[1].clone()) { | ||
| Ok(attributes) => attributes, |
There was a problem hiding this comment.
if you are having an Option, should you now match to Some?
There was a problem hiding this comment.
We have three scenarios:
A) We receive a PayloadAttributes Ok(Some(attributes)) -> We return Some(attributes)
B) We receive a null payload attributes Ok(None) -> We return None
C) We receive an invalid PayloadAttributes Err() -> We show an error message and return None
In both A & B we just return whatever is inside the Ok()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we receive a payload with null payload attributes we return an error:
Could not parse params invalid type: null, expected struct PayloadAttributesV3, when this is perfectly acceptable behaviourDescription
Option<PayloadAttributes>instead of justPayloadAttributesCloses #issue_number