chore(levm): daily report levm tests & diff #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkrause98
changed the title
|
The amount of lines of code in the project has not changed. |
|
The amount of lines of code in the project has not changed. |
mpaulucci
reviewed
Jan 9, 2025
|
mpaulucci
reviewed
Jan 9, 2025
| @@ -59,6 +59,7 @@ jobs: | |||
| with: | |||
| name: ${{ matrix.test.file_name }}_${{ matrix.vm }}_logs | |||
| path: hive/workspace/logs/*-*.json | |||
| if-no-files-found: error | |||
mpaulucci
reviewed
Jan 9, 2025
| env: | ||
| url: ${{ secrets.ETHREX_L2_SLACK_WEBHOOK }} | ||
| run: sh .github/scripts/publish_levm_ef_tests_summary.sh | ||
| # - name: Post results to ethrex L2 slack channel |
There was a problem hiding this comment.
I think we don't want to post to this channel for now, but I might be wrong, I have to double check with @ilitteri
There was a problem hiding this comment.
Yes, we can remove these commented lines and add them later.
mpaulucci
approved these changes
Jan 9, 2025
ilitteri
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to compare the default feature build vs the one using levm, since we want
to be aware of possible regressions while using said vm.
Closes #1645.
Closes #1627