-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(l1, l2, levm): fix shared dependencies in workspace Cargo.toml
#1680
base: main
Are you sure you want to change the base?
Conversation
The amount of lines of code in the project has not changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good, one comment regarding the l2
crate
The amount of lines of code in the project has not changed. |
1 similar comment
The amount of lines of code in the project has not changed. |
The amount of lines of code in the project has not changed. |
Benchmark Results ComparisonPR ResultsBenchmark Results: Factorial
Benchmark Results: Fibonacci
Main ResultsBenchmark Results: Factorial
Benchmark Results: Fibonacci
|
anyhow = "1.0.86" | ||
directories = "5.0.1" | ||
tinyvec = "1.6.0" | ||
revm = { version = "14.0.3", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait, why do we want this here at the top level? I think only one crate should have this as a dependency (vm), if there is more than one crate using this it means there's a problem
Cargo.toml
ethrex
libsserde_json
versionserde
versionbytes
version