Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): bump_up revm #1687

Closed
wants to merge 1 commit into from

Conversation

fborello-lambda
Copy link
Contributor

Motivation

We had different versions for revm, we should have unify and bump-up the version to stay up to date.

Description

  • Unify revm versions
  • BumpUp revm version
  • BumpUp Rust version → newer revm versions depend on rust >= 1.82

@fborello-lambda fborello-lambda self-assigned this Jan 10, 2025
Copy link

+--------------------------------------------------------------------+-------+------+
| File                                                               | Lines | Diff |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/blockchain/blockchain.rs    | 183   | +14  |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/l2/proposer/l1_committer.rs | 370   | +2   |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/execution_db.rs          | 184   | +2   |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/precompiles.rs  | 830   | -110 |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/vm.rs                    | 770   | -44  |
+--------------------------------------------------------------------+-------+------+

Total lines changed: +172

Copy link

Benchmark Results Comparison

PR Results

Benchmark Results: Factorial

Command Mean [s] Min [s] Max [s] Relative
revm_factorial 6.999 ± 0.016 6.964 7.024 1.00
levm_factorial 26.079 ± 0.209 25.815 26.280 3.73 ± 0.03

Benchmark Results: Fibonacci

Command Mean [s] Min [s] Max [s] Relative
revm_fibonacci 6.768 ± 0.023 6.733 6.798 1.00
levm_fibonacci 23.523 ± 0.116 23.319 23.697 3.48 ± 0.02

Main Results

Benchmark Results: Factorial

Command Mean [s] Min [s] Max [s] Relative
revm_factorial 7.550 ± 0.889 7.048 10.068 1.00
levm_factorial 26.627 ± 0.239 26.317 27.201 3.53 ± 0.42

Benchmark Results: Fibonacci

Command Mean [s] Min [s] Max [s] Relative
revm_fibonacci 7.562 ± 0.681 7.282 9.495 1.00
levm_fibonacci 24.345 ± 0.142 24.130 24.506 3.22 ± 0.29

@fborello-lambda
Copy link
Contributor Author

We should tackle this in the future, we need to bump up rust version to 1.82, but the prover doesn't support rust1.82 at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant