Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(l1): send our advertised tcp ports in discovery #1785

Merged
merged 3 commits into from
Jan 23, 2025
Merged

fix(l1): send our advertised tcp ports in discovery #1785

merged 3 commits into from
Jan 23, 2025

Conversation

MarcosNicolau
Copy link
Contributor

@MarcosNicolau MarcosNicolau commented Jan 23, 2025 •
edited
Loading

Motivation

In discovery, we missed sending our local node TCP port when sending ping and pong messages.

Description

This pr fixes it by sending our local node configured ports.

Closes None

@MarcosNicolau MarcosNicolau requested a review from a team as a code owner January 23, 2025 15:30
@github-actions GitHub Actions
Copy link 

| File                                                         | Lines | Diff |
+--------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/net.rs | 1131  | -7   |
+--------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/vm.rs     | 1271  | -4   |
+--------------------------------------------------------------+-------+------+

Total lines added: 0
Total lines removed: 11
Total lines changed: 11

fmoletta
fmoletta approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MarcosNicolau MarcosNicolau added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit e340bd9 Jan 23, 2025
19 checks passed
@MarcosNicolau MarcosNicolau deleted the fix/tcp-port-discovery branch January 23, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkenan Arkenan Arkenan approved these changes

@ilitteri ilitteri ilitteri approved these changes

@fmoletta fmoletta fmoletta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarcosNicolau @Arkenan @ilitteri @fmoletta