Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(l1): change the fork check for greater or equal rather than equal on beacon call #1864

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix(l1): change the fork check for greater or equal rather than equal on beacon call #1864

merged 1 commit into from
Jan 31, 2025

Conversation

tomip01
Copy link
Contributor

@tomip01 tomip01 commented Jan 31, 2025

Motivation

In this PR we change the check for doing the beacon root call to make it work for future forks begging in Cancun

Description

Change the equal assertion of the fork to a greater or equal assertion

@tomip01 tomip01 added the bug Something isn't working label Jan 31, 2025
@tomip01 tomip01 self-assigned this Jan 31, 2025
@tomip01 tomip01 requested a review from a team as a code owner January 31, 2025 17:34
@github-actions GitHub Actions
Copy link 

| File                                                                           | Lines | Diff |
+--------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/cmd/ethrex/ethrex.rs                           | 351   | -34  |
+--------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/bootnode.rs              | 48    | +48  |
+--------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/discv4/server.rs         | 683   | +7   |
+--------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/net.rs                   | 156   | +2   |
+--------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/rlpx/connection.rs       | 388   | -6   |
+--------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/rlpx/eth/transactions.rs | 280   | -8   |
+--------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/rlpx/utils.rs            | 80    | -3   |
+--------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/types.rs                 | 246   | -82  |
+--------------------------------------------------------------------------------+-------+------+

Total lines added: +57
Total lines removed: 133
Total lines changed: 190

fborello-lambda
fborello-lambda approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@fborello-lambda fborello-lambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's required. Good Job spotting them.

@ilitteri ilitteri added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 89c976f Jan 31, 2025
20 checks passed
@ilitteri ilitteri deleted the fix/beacon-call-fork branch January 31, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilitteri ilitteri ilitteri approved these changes

@fmoletta fmoletta fmoletta approved these changes

@fborello-lambda fborello-lambda fborello-lambda approved these changes

Assignees

@tomip01 tomip01

Labels
bug Something isn't working
Projects
ethrex_l1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomip01 @ilitteri @fmoletta @fborello-lambda