refactor(l1): cleanup the public api of rpc crate #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
rodrigo-o
approved these changes
Apr 1, 2025
Comment on lines
+87
to
+103
| pub storage: Store, | ||
| pub blockchain: Arc<Blockchain>, | ||
| pub jwt_secret: Bytes, | ||
| pub local_p2p_node: Node, | ||
| pub local_node_record: NodeRecord, | ||
| pub active_filters: ActiveFilters, | ||
| pub syncer: Arc<TokioMutex<SyncManager>>, | ||
| #[cfg(feature = "based")] | ||
| gateway_eth_client: EthClient, | ||
| pub gateway_eth_client: EthClient, | ||
| #[cfg(feature = "based")] | ||
| gateway_auth_client: EngineClient, | ||
| pub gateway_auth_client: EngineClient, | ||
| #[cfg(feature = "based")] | ||
| gateway_pubkey: Public, | ||
| pub gateway_pubkey: Public, | ||
| #[cfg(feature = "l2")] | ||
| valid_delegation_addresses: Vec<Address>, | ||
| pub valid_delegation_addresses: Vec<Address>, | ||
| #[cfg(feature = "l2")] | ||
| sponsor_pk: SecretKey, | ||
| pub sponsor_pk: SecretKey, |
There was a problem hiding this comment.
Nit: What was the reason to make them public? I'm asumming is related to the changes in how other modules import now RpcApiContext but not entirely sure why, I may be missing something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Having a clean and explicit
lib.rsthat only exposes necesary functions to the outsideThe idea is for every crate:
Some crates from the workspace are already like this, others are in the process of being refactored.