fix(core): timeout due to node inactivity instead of total load test time #2530
+1,163
−591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
Arkenan
changed the title
jrchatruc
approved these changes
May 15, 2025
fkrause98
approved these changes
May 15, 2025
fmoletta
pushed a commit
that referenced
this pull request
May 15, 2025
…time (#2530) Changes: - Timeout is now smarter. Instead of waiting a fixed amount of time (e.g. 10 minutes) for the whole load test to happen, which is a bit unpredictable, the load test waits at most 1 minute (configurable) of no-updates from the node. This way it's less machine dependent and more based on responsiveness. - load-test-ci.json is fixed to be similar to perf-ci.json, but in prague and with the system smart contracts from l1-dev.json deployed. - logs are re-added. - Readme si fixed. - Re-add flamegraph reporter to CI so they are generated on every push. Closes #2522
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
…time (lambdaclass#2530) Changes: - Timeout is now smarter. Instead of waiting a fixed amount of time (e.g. 10 minutes) for the whole load test to happen, which is a bit unpredictable, the load test waits at most 1 minute (configurable) of no-updates from the node. This way it's less machine dependent and more based on responsiveness. - load-test-ci.json is fixed to be similar to perf-ci.json, but in prague and with the system smart contracts from l1-dev.json deployed. - logs are re-added. - Readme si fixed. - Re-add flamegraph reporter to CI so they are generated on every push. Closes lambdaclass#2522
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Closes #2522