-
Notifications
You must be signed in to change notification settings - Fork 106
feat(l1,l2,replay): mempool max size parameter #4639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a configurable mempool max size parameter to the ethrex command and blockchain components. Previously, the mempool size was hardcoded to 10,000 transactions.
- Adds
--mempool.maxsize
CLI argument with default value of 10,000 - Updates all blockchain constructor calls to accept the max mempool size parameter
- Replaces hardcoded MEMPOOL_MAX_SIZE constant with configurable parameter
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
cmd/ethrex/cli.rs | Adds mempool_max_size CLI parameter with default value |
cmd/ethrex/initializers.rs | Updates init_blockchain to accept max_mempool_size parameter |
cmd/ethrex/l2/initializers.rs | Passes mempool max size from CLI options to blockchain init |
cmd/ethrex_replay/src/cli.rs | Uses constant for mempool size in replay operations |
crates/blockchain/blockchain.rs | Updates Blockchain constructors to accept max_mempool_size |
crates/blockchain/mempool.rs | Removes hardcoded constant, adds max_mempool_size field |
crates/blockchain/smoke_test.rs | Updates test blockchain creation with mempool size parameter |
crates/networking/p2p/sync.rs | Adds dummy mempool size constant for syncing |
tooling/ef_tests/blockchain/test_runner.rs | Uses test constant for mempool size in EF tests |
tooling/ef_tests/state_v2/src/modules/block_runner.rs | Uses test constant for mempool size in state tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Lines of code reportTotal lines added: Detailed view
|
Motivation
We want to make the mempool max size a parameter
Description
Adds the mempool max size as a parameter to ethrex command
Closes #4600