-
Notifications
You must be signed in to change notification settings - Fork 106
feat(l1): keep downloading big storage leaves on pivot jump during snap sync #4645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view
|
fedacking
approved these changes
Sep 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
iovoid
approved these changes
Sep 25, 2025
MegaRedHand
requested changes
Sep 26, 2025
}; | ||
tasks_queue_not_started.push_back(task); | ||
task_count += 1; | ||
// TODO: DRY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please dry this
Closing since it was included in #4689 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our current snap sync implementation stops downloading an account's storage leaves if there's a pivot jump. This is a big deal because in every network there are very few contracts that have almost all of the storage; this means in big networks like Sepolia or Mainnet we currently heal most of the storage tries in their entirety.
This PR makes it so the snap sync step that downloads storage leaves keeps track of big accounts to resume their download when a pivot jump occurs.
Description
Closes #issue_number