-
Notifications
You must be signed in to change notification settings - Fork 106
test(l1): full Sync re org test #4673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gianbelinche
wants to merge
40
commits into
main
Choose a base branch
from
test/full-sync-reorg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+323
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-reorg-smoke-test
Lines of code reportTotal lines added: Detailed view
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to test different reorg situations.
Description
We want to test a reorg where we have 3 nodes. One with the base chain, one with a side chain and a third one where we want to full sync the base chain. As per this issue #4617
Adds a test for that scenario, this test is currently flaky, since 50% of the times it will choose the peer with the base chain, working fine, but the other 50% it will choose the peer with the side chain, where it currently fails.
Since there is always a 50% chance of failing, we run the test 30 times to make sure the probability of failure is small enough.
Other tests are also added:
test_reorg_back_to_base
: Tests a node that syncs to a side chain and wants to sync back to the base chaintest_reorg_back_to_base_with_common_ancestor
: Same test as before but the base chain has blockstest_storage_slots_reorg
: test using a simple contract that sets a storage slot as received by calldatano_reorgs_full_sync_smoke_test
: Tests a normal fullsync without reorgsCloses