perf(l2): avoid redundant String allocations in BlocksTable::render #5207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In blocks.rs::render(), there are unnecessary allocations due to .to_string()on existing String.
Description
Replaced .to_string() calls on existing String values with borrowed references when building Spans in
BlocksTable::render() (crates/l2/monitor/widget/blocks.rs).
This avoids unnecessary allocations and copies at render time. ratatui’s Span::styled takes Into<Cow<'_, str>>, so &String/&str can be used directly. Aligned with existing usage in mempool.rs.