chore(l2): include zkVM ELFs and VKs in the releases #5244
Merged
+112
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for building and distributing RISC0 ELF files alongside verification keys in the release workflow. The key changes include writing the RISC0 ELF binary to disk during the build process and updating the GitHub workflow to upload both ELF files and verification keys as release artifacts.
- Extracts and writes the RISC0 ELF binary to a file during the build process
- Adds a new CI job to build guest programs for both SP1 and RISC0 zkVMs
- Updates the release workflow to download and include verification keys as separate artifacts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/l2/prover/src/guest_program/build.rs | Adds extraction and writing of RISC0 ELF binary to file system |
| .github/workflows/tag_release.yaml | Adds new job to build guest programs and handle verification keys as separate artifacts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/tag_release.yaml
Outdated
Comment on lines
199
to
200
| mv crates/l2/prover/src/guest_program/src/${{ matrix.zkvm }}/out/riscv32im-risc0-vk ethrex-riscv32im-risc0-elf-${{ github.ref_name}} | ||
| mv crates/l2/prover/src/guest_program/src/${{ matrix.zkvm }}/out/riscv32im-risc0-vk ${{ matrix.zkvm }}_verification_keys/ethrex-riscv32im-risc0-vk-${{ github.ref_name}} |
There was a problem hiding this comment.
Missing closing brace in template expression. Both lines should use ${{ github.ref_name }} with a closing brace, not ${{ github.ref_name}}.
Suggested change
| mv crates/l2/prover/src/guest_program/src/${{ matrix.zkvm }}/out/riscv32im-risc0-vk ethrex-riscv32im-risc0-elf-${{ github.ref_name}} | |
| mv crates/l2/prover/src/guest_program/src/${{ matrix.zkvm }}/out/riscv32im-risc0-vk ${{ matrix.zkvm }}_verification_keys/ethrex-riscv32im-risc0-vk-${{ github.ref_name}} | |
| mv crates/l2/prover/src/guest_program/src/${{ matrix.zkvm }}/out/riscv32im-risc0-vk ethrex-riscv32im-risc0-elf-${{ github.ref_name }} | |
| mv crates/l2/prover/src/guest_program/src/${{ matrix.zkvm }}/out/riscv32im-risc0-vk ${{ matrix.zkvm }}_verification_keys/ethrex-riscv32im-risc0-vk-${{ github.ref_name }} |
Lines of code reportTotal lines added: Detailed view |
ilitteri
commented
Nov 8, 2025
.github/workflows/tag_release.yaml
Outdated
| uses: actions/download-artifact@v4 | ||
| with: | ||
| path: ./bin | ||
| pattern: "*_verification_keys" # sp1_verification_keys, risc0_verification_keys |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if the pattern needs to be instead "*_verification_keys/*"
Contributor
There was a problem hiding this comment.
I'd put VKs and ELFs in a .tar file so we don't add 5 more files
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ManuelBilbao
approved these changes
Nov 10, 2025
.github/workflows/tag_release.yaml
Outdated
Comment on lines
222
to
223
| - name: Checkout code | ||
| uses: actions/checkout@v4 |
tomip01
approved these changes
Nov 10, 2025
| finalize-release: | ||
| needs: | ||
| - build-ethrex | ||
| - build-ethrex-guest |
Contributor
There was a problem hiding this comment.
I think this is not needed since it is required in package-ethrex-guest
xqft
pushed a commit
that referenced
this pull request
Nov 11, 2025
**Motivation** We need releases of ethrex's ELFs and VKs to use independently for proving L1 blocks execution. **Description** - Adds a `build-ethrex-guest` workflow to run with a mattrix strategy (for sp1 and risc0) that builds the `guest_program` crate with the features `sp1` and `risc0`. We need this as a separate job and cannot reuse the builds from ubuntu-22.04 for l2_gpu because the guest program being built there is different than the one we need for statelessly verifying L1 blocks. - Adds a `package-ethrex-guests` workflow to create `ethrex-guests.tar.gz` compressing SP1 and RISC0 elf and vks. - RISC0's ELF file is now generated. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need releases of ethrex's ELFs and VKs to use independently for proving L1 blocks execution.
Description
build-ethrex-guestworkflow to run with a mattrix strategy (for sp1 and risc0) that builds theguest_programcrate with the featuressp1andrisc0. We need this as a separate job and cannot reuse the builds from ubuntu-22.04 for l2_gpu because the guest program being built there is different than the one we need for statelessly verifying L1 blocks.package-ethrex-guestsworkflow to createethrex-guests.tar.gzcompressing SP1 and RISC0 elf and vks.