perf(l1): use asm ffi keccak #5247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
MegaRedHand
reviewed
Nov 11, 2025
Benchmark for c5c879eClick to view benchmark
|
jrchatruc
approved these changes
Nov 11, 2025
Benchmark for 5ffb6bdClick to view benchmark
|
Benchmark for a6f1fadClick to view benchmark
|
MegaRedHand
approved these changes
Nov 11, 2025
pablodeymo
reviewed
Nov 11, 2025
Comment on lines
+35
to
+43
| impl Default for Keccak256 { | ||
| fn default() -> Self { | ||
| Self { | ||
| state: State::default(), | ||
| tail_buf: [0; BLOCK_SIZE], | ||
| tail_len: 0, | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This can be derived in the declaration of the struct. All the fields are taking their default value.
Contributor
There was a problem hiding this comment.
Rust let go of our hands. It can't be done because arrays only implement default up to a certain number less than 136.
pablodeymo
reviewed
Nov 11, 2025
crates/common/crypto/keccak/mod.rs
Outdated
Comment on lines
48
to
52
| Self { | ||
| state: State::default(), | ||
| tail_buf: [0; BLOCK_SIZE], | ||
| tail_len: 0, | ||
| } |
Contributor
There was a problem hiding this comment.
you can call default() here.
Benchmark for a22c1faClick to view benchmark
|
Benchmark for 21eb90eClick to view benchmark
|
MegaRedHand
reviewed
Nov 11, 2025
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
pablodeymo
reviewed
Nov 11, 2025
Comment on lines
36
to
40
| // Hash value for an empty trie, equal to keccak(RLP_NULL) | ||
| pub static ref EMPTY_TRIE_HASH: H256 = H256::from_slice( | ||
| &Keccak256::digest([RLP_NULL]), | ||
| pub static ref EMPTY_TRIE_HASH: H256 = H256( | ||
| keccak_hash([RLP_NULL]), | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
we should refactorize the use of this lazy_static! and use std LazyLock/LazyCell.
Contributor
There was a problem hiding this comment.
I will file an issue with this task.
Collaborator
There was a problem hiding this comment.
We should move the EMPTY_KECCACK_HASH constant to this module too. (and fix that horrible typo too)
MegaRedHand
reviewed
Nov 11, 2025
| @@ -0,0 +1,855 @@ | |||
| // Modified: | |||
| // - Ran `cpp` to substitute constants. | |||
Collaborator
There was a problem hiding this comment.
We should paste the full command here.
Benchmark for b2647ebClick to view benchmark
|
pablodeymo
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace sha3 keccak to an assembly version using ffi