-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(l1): enhance el assertoor ci test by cherrypicking more checks #963
Conversation
Are all blocks proposed by our execution client empty blocks (i.e no transactions)? |
In most of the test, yes, our blocks are empty. But, due to the addition of the |
But if our blocks have blobs, they have a associated transaction too, right? |
Yes, exactly. But just to be clear that happens only while that specific test is running, for most of the rest of the run our blocks are empty. |
Ok, but at least we have one test with transactions proposed by us! |
Motivation
This PR tries to add as much test as possible to our assertoor CI run.
Description
The idea is to add every check that is useful for validating the el execution without incurring in long running times to avoid making the CI slower. Right now every useful check from the supported is added except for:
check_consensus_finality
| time: ~10mcheck_consensus_attestation_stats
| time: ~10mApart from checks, we are not using most of the
generate_*
tasks due to timing or errors:run_transaction_test
| time: ~10mrun_blob_transaction_test
| time: ~6mrun_opcodes_transaction_test
| time: ~5m (We have issues processing some of the transactions)For the already available assertor playbooks, see here.
The
run_blob_transaction_test
is the only one added until now from transaction checks and the total test take nearly 15m (which is less than the largest hive test in the CI).Closes #953