Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(l2): prove block validation #973

Merged
merged 4 commits into from
Oct 25, 2024
Merged

feat(l2): prove block validation #973

merged 4 commits into from
Oct 25, 2024

Conversation

xqft
Copy link
Contributor

@xqft xqft commented Oct 24, 2024

Motivation

the block execution program is missing many validation steps, this PR adds them.

Description

  • adds validation steps to zkVM program

@xqft xqft marked this pull request as ready for review October 25, 2024 17:48
@xqft xqft requested a review from a team as a code owner October 25, 2024 17:48
fborello-lambda
fborello-lambda approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@fborello-lambda fborello-lambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, i'm going to integrate these changes with #969

@fborello-lambda fborello-lambda merged commit 7f84c9e into l2/integrate_cache_db Oct 25, 2024
1 check passed
@fborello-lambda fborello-lambda deleted the l2/prove_validation branch October 25, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fborello-lambda fborello-lambda fborello-lambda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xqft @fborello-lambda