Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(l2): cli target #984

Merged
merged 2 commits into from
Oct 25, 2024
Merged

refactor(l2): cli target #984

merged 2 commits into from
Oct 25, 2024

Conversation

ilitteri
Copy link
Contributor

Motivation

To use make cli to install the CLI instead of building it.

@ilitteri ilitteri added the L2 label Oct 25, 2024
@ilitteri ilitteri added this to the [L2] 1 - Basic L2 milestone Oct 25, 2024
@ilitteri ilitteri self-assigned this Oct 25, 2024
@ilitteri ilitteri requested a review from a team as a code owner October 25, 2024 18:10
Copy link
Contributor

@fborello-lambda fborello-lambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ManuelBilbao ManuelBilbao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fborello-lambda fborello-lambda added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 0e5d8a2 Oct 25, 2024
6 checks passed
@fborello-lambda fborello-lambda deleted the refactor_cli_target_in_make branch October 25, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants