-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix valtimer singularity pulling you inside obstacles #459
Fix valtimer singularity pulling you inside obstacles #459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR works amazingly well! Congrats!
Left a comment to refactor some code.
While testing the corrections i noticed that if you try to tp inside an obstacle valtimer is walking to the destination instead of teleportong : Screen.Recording.2024-04-15.at.4.07.51.PM.movThis is due to how the client handle the teleport and the result of the first destination that we sent to the cleint dont being the same as the final destination. To fix this i calculated the final destination and then store it when you first execute the skill Screen.Recording.2024-04-15.at.4.11.24.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Valtimer was pulling people inside the colliders and with his tp you were able to go inside rocks
to test this add this to the config file in the "obstacles" list and check that valtimer don't go inside of the obstacle and move a player close to it and try to move it inside of the obstacle:
Emerald