Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix valtimer singularity pulling you inside obstacles #459

Merged

Conversation

agustinesco
Copy link
Contributor

@agustinesco agustinesco commented Apr 9, 2024

Valtimer was pulling people inside the colliders and with his tp you were able to go inside rocks

to test this add this to the config file in the "obstacles" list and check that valtimer don't go inside of the obstacle and move a player close to it and try to move it inside of the obstacle:

Emerald
     {
        "position": {
          "x": 0.0,
          "y": 0.0
        },
        "vertices": [
          {
            "x": 0.0,
            "y": 3000.0
          },
          {
            "x": 2000.0,
            "y": 1000.0
          },
          {
            "x": 2000.0,
            "y": -1000.0
          },
          {
            "x": 0.0,
            "y": -3000.0
          },
          {
            "x": -2000.0,
            "y": -1000.0
          },
          {
            "x": -2000.0,
            "y": 1000.0
          }
        ],
        "radius": 0.0,
        "shape": "polygon"
      }

@agustinesco agustinesco marked this pull request as ready for review April 10, 2024 15:57
Copy link
Collaborator

@Nico-Sanchez Nico-Sanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR works amazingly well! Congrats!

Left a comment to refactor some code.

apps/arena/native/physics/src/lib.rs Outdated Show resolved Hide resolved
@agustinesco
Copy link
Contributor Author

While testing the corrections i noticed that if you try to tp inside an obstacle valtimer is walking to the destination instead of teleportong :

Screen.Recording.2024-04-15.at.4.07.51.PM.mov

This is due to how the client handle the teleport and the result of the first destination that we sent to the cleint dont being the same as the final destination. To fix this i calculated the final destination and then store it when you first execute the skill

Screen.Recording.2024-04-15.at.4.11.24.PM.mov

Copy link
Contributor

@AminArria AminArria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agustinesco agustinesco merged commit e7d6ef1 into main Apr 17, 2024
1 check passed
@agustinesco agustinesco deleted the fix-valtimer-singularity-pulling-you-inside-obstacles branch April 17, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants