-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-709] implement dynamic obstacles #715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I didn't test in Unity (had an issue with it on my laptop, not related to PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job you did here @agustinesco ! Left some comments about the config and about a possible refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @agustinesco !
* north-eastern spike * add south-western spikes * fix clipping for top obstacle * Fix base statuses for spikes --------- Co-authored-by: tvillegas98 <tvillegas@fi.uba.ar> Co-authored-by: agustinesco <agustinesco@outlook.es>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job fixing the bottlenecks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!! Tested locally and on my iOS device
Important
Merge alongside this client pr
Motivation
We need a feature to add dynamic walls they'll work as a normal obstacle but they can be deactivated so player can go through them
Also when an obstacle change state we should trigger a mechanic
Closes #709
Summary of changes
How to test it?
Replace the obstacle with the same name in the config.json file with:
then go to this link and play a match, you should see an obstacle change colors:
If you wanna trigger this pr in the unity client you must delete this component from the
obstacleCollider
prefab:and when the obstacle is down you should be able to go through the obstacle in the client too
Checklist