-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
And
component
#72
Merged
ilitteri
merged 46 commits into
generate_constraints_in_black_box_functions
from
and_component
Mar 30, 2023
Merged
And
component
#72
ilitteri
merged 46 commits into
generate_constraints_in_black_box_functions
from
and_component
Mar 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/noir_backend_using_gnark into and_component
…/noir_backend_using_gnark into and_component
Base automatically changed from
assert_is_boolean_constraint
to
generate_constraints_in_black_box_functions
March 27, 2023 19:39
…com:lambdaclass/noir_backend_using_gnark into and_component
jrchatruc
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
And
component which performs the logic AND operation between felts.The following components were implemented for this:
toBinaryConversion
: converts a felt to its binary representation and generates constraints for it.fromBinaryConversion
: converts some binary representation into a felt and generates constraints for it.add
: generates constraints for adding two felts.mul
: generates constraints for multiplying two felts.