Skip to content

Commit

Permalink
Add basic CI (#24)
Browse files Browse the repository at this point in the history
* Add basic CI

* Use nighly rustfmt

* Fix format

* Fix clippy

* Rename job

* Install lld

* Remove all features

* Only clippy blockifier
  • Loading branch information
JulianGCalderon authored Dec 3, 2024
1 parent ec32deb commit bfc5b6b
Show file tree
Hide file tree
Showing 3 changed files with 56 additions and 9 deletions.
49 changes: 49 additions & 0 deletions .github/workflows/replay.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
name: Replay

on:
push:
branches: [main, replay]
pull_request:

jobs:
clippy:
runs-on: ubuntu-latest
env:
MLIR_SYS_190_PREFIX: /usr/lib/llvm-19/
LLVM_SYS_191_PREFIX: /usr/lib/llvm-19/
TABLEGEN_190_PREFIX: /usr/lib/llvm-19/
CAIRO_NATIVE_RUNTIME_LIBRARY: libcairo_native_runtime.a
steps:
- uses: actions/checkout@v4
with:
# required to clone native as a git submodule
submodules: recursive
- uses: dtolnay/rust-toolchain@1.82.0
with:
components: clippy
- uses: Swatinem/rust-cache@v2
- name: Add LLVM Debian repository
uses: myci-actions/add-deb-repo@10
with:
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-19 main
repo-name: llvm-repo
keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
- name: Install lld
run: sudo apt install lld
- name: Install LLVM
run: sudo apt-get install llvm-19 llvm-19-dev llvm-19-runtime clang-19 clang-tools-19 lld-19 libpolly-19-dev libmlir-19-dev mlir-19-tools
- name: Run cargo clippy
run: |
cd crates/blockifier
cargo clippy --all-targets --all-features --no-deps
format:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@nightly
with:
toolchain: nightly-2023-10-19
components: rustfmt
- name: Run cargo fmt
run: cargo +nightly-2023-10-19 fmt --all -- --check
4 changes: 1 addition & 3 deletions crates/blockifier/src/execution/contract_class.rs
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,7 @@ impl RunnableCompiledClass {
Self::V0(class) => class.estimate_casm_hash_computation_resources(),
Self::V1(class) => class.estimate_casm_hash_computation_resources(),
#[cfg(feature = "cairo_native")]
Self::V1Native(_) => {
ExecutionResources::default()
}
Self::V1Native(_) => ExecutionResources::default(),
}
}

Expand Down
12 changes: 6 additions & 6 deletions crates/blockifier/src/execution/execution_utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -148,12 +148,12 @@ pub fn execute_entry_point_call(
// context,
// )
// } else {
native_entry_point_execution::execute_entry_point_call(
call,
compiled_class,
state,
context,
)
native_entry_point_execution::execute_entry_point_call(
call,
compiled_class,
state,
context,
)
// }
}
}
Expand Down

0 comments on commit bfc5b6b

Please sign in to comment.