Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process block bug #11

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix process block bug #11

merged 1 commit into from
Oct 15, 2024

Conversation

JulianGCalderon
Copy link

@JulianGCalderon JulianGCalderon commented Oct 14, 2024

Fixes lambdaclass/cairo_native#845, in conjunction with lambdaclass/cairo_native#851.

sha256_process_block syscall should modify the received state with the new state, but instead of doing this, it copies the value and modifies the copied version, leaving the old state untouched.

This PR fixes it.

All transactions mentioned in the issue are now working correctly.

@JulianGCalderon JulianGCalderon marked this pull request as ready for review October 14, 2024 20:59
@pefontana pefontana merged commit 600b802 into native2.8.x Oct 15, 2024
0 of 52 checks passed
@pefontana pefontana deleted the fix-process-block-bug branch October 15, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants