Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

estimate_fee() does not skip fee transfer #702

Closed
kkovaacs opened this issue Jun 28, 2023 · 0 comments · Fixed by #713
Closed

estimate_fee() does not skip fee transfer #702

kkovaacs opened this issue Jun 28, 2023 · 0 comments · Fixed by #713
Assignees
@SantiagoPittella
Labels
bug Something isn't working
Milestone
starknet_in_rust ...

Comments

@kkovaacs
Copy link
Contributor

Currently there's no way in the starknet_in_rust API to skip the fee transfer.

In cairo-lang we were using InternalAccountTransactionForSimulate which skips fee transfers entirely.

This is important, since we're interested in the fee estimation even if the account does not currently have sufficient funds.
@juanbono juanbono added the bug Something isn't working label Jun 28, 2023
@juanbono juanbono moved this to Todo in Starknet Jun 28, 2023
@juanbono juanbono added this to the starknet_in_rust 0.1.1 milestone Jun 28, 2023
@SantiagoPittella SantiagoPittella self-assigned this Jun 30, 2023
@SantiagoPittella SantiagoPittella mentioned this issue Jul 3, 2023
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in Starknet Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SantiagoPittella SantiagoPittella

Labels
bug Something isn't working
Projects
Starknet
Status: Done
Milestone
starknet_in_rust 0.1.1
Development

Successfully merging a pull request may close this issue.

remove fee transfer from fee estimation lambdaclass/starknet_in_rust
3 participants
@kkovaacs @juanbono @SantiagoPittella