Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

remove fee transfer from fee estimation #713

Merged
merged 34 commits into from
Jul 3, 2023

Conversation

SantiagoPittella
Copy link
Collaborator

@SantiagoPittella SantiagoPittella commented Jul 3, 2023

remove fee transfer from fee estimation

Description

Add flag skip fee transfer in the fee_estimation function.

Closes #702

Made on top of #706

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

Merging #713 (49a5704) into main (3d84f66) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
+ Coverage   92.39%   92.43%   +0.03%     
==========================================
  Files          52       52              
  Lines       11826    11866      +40     
==========================================
+ Hits        10927    10968      +41     
+ Misses        899      898       -1     
Impacted Files Coverage Δ
src/lib.rs 98.71% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

@SantiagoPittella SantiagoPittella marked this pull request as ready for review July 3, 2023 17:48
@SantiagoPittella SantiagoPittella changed the title WIP: remove fee transfer from fee estimation remove fee transfer from fee estimation Jul 3, 2023
Copy link
Contributor

@matias-gonz matias-gonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the test estimate_fee_test: we can remove the part where we add balance to the account because it will skip the fee transfer

@juanbono juanbono added this pull request to the merge queue Jul 3, 2023
Merged via the queue into main with commit d5aaf0e Jul 3, 2023
@juanbono juanbono deleted the skip-fee-transfer-on-estimate-fee branch July 4, 2023 19:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

estimate_fee() does not skip fee transfer
5 participants