Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Declare transaction hash mismatch #758

@kkovaacs

Description

@kkovaacs

Looks like the computed transaction hashes for Declare v1 transactions are incorrect.

In particular, these lines look suspicious:

    let (calldata, additional_data) = if version.is_zero() {
        (vec![class_hash], vec![nonce])
    } else {
        (Vec::new(), vec![class_hash])
    };

I think it should be exactly the other way around (!version.is_zero()). Adding a test case that tests this should be trivial with this class.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions