Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Cairo native: Implement testing syscalls #1083

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Oct 18, 2023

Implements most testing syscalls in cairo native

Implements:
set_account_contract_address
set_block_number
set_block_timestamp
set_caller_address
set_chain_id
set_contract_address
set_max_fee
set_nonce
set_signature
set_transaction_hash
set_version

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@edg-l edg-l changed the base branch from main to update_cairo_native October 18, 2023 11:42
@toni-calvin
Copy link
Contributor

Should we add integration tests?

Copy link
Collaborator

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edg-l
Copy link
Member Author

edg-l commented Oct 18, 2023

Should we add integration tests?

we can't really test this, as they arent wired up in cairo-native yet

@edg-l edg-l merged commit bd529bc into update_cairo_native Oct 18, 2023
7 checks passed
edg-l added a commit that referenced this pull request Oct 18, 2023
@edg-l edg-l mentioned this pull request Oct 18, 2023
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants