Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Conversation

@fmoletta
Copy link
Contributor

Currently in main, running cargo test from within the rpc-state-reader source fails, as the code was changed to support the changes made to starknet_in_rust under the cairo-native feature flag without including said feature. This PR adds the cairo-native feature flag to the rpc-state-reader and gates the changes under this flag, so that the tests pass when running make test, and also when running cargo test from within the rpc-state-reader crate.

@fmoletta fmoletta marked this pull request as ready for review November 21, 2023 14:10
@juanbono juanbono enabled auto-merge November 21, 2023 14:19
@juanbono juanbono added this pull request to the merge queue Nov 21, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1147 (59ed9a2) into main (5763f6b) will decrease coverage by 0.16%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1147      +/-   ##
==========================================
- Coverage   89.69%   89.54%   -0.16%     
==========================================
  Files          50       50              
  Lines       14351    14351              
==========================================
- Hits        12872    12850      -22     
- Misses       1479     1501      +22     

see 2 files with indirect coverage changes

Merged via the queue into main with commit db29647 Nov 21, 2023
@juanbono juanbono deleted the fix-rpc-feature branch November 21, 2023 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants