This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fix actual_fee calculation for v0 #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
approved these changes
Jul 18, 2023
Oppen
approved these changes
Jul 18, 2023
juanbono
suggested changes
Jul 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 91.73% 91.75% +0.02%
==========================================
Files 54 54
Lines 12836 12896 +60
==========================================
+ Hits 11775 11833 +58
- Misses 1061 1063 +2
|
juanbono
approved these changes
Jul 21, 2023
kkovaacs
reviewed
Jul 21, 2023
SantiagoPittella
suggested changes
Jul 24, 2023
matias-gonz
requested review from
kkovaacs,
Oppen and
SantiagoPittella
and removed request for
kkovaacs and
Oppen
SantiagoPittella
approved these changes
Jul 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix actual_fee calculation for v0
Description
The
min(actual_fee, max_fee) * FEE_FACTORshouldn't be calculated for v0