This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Use cairo lang 2.1.0 rc2 #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #863 +/- ##
==========================================
- Coverage 91.26% 91.21% -0.05%
==========================================
Files 54 54
Lines 13392 13401 +9
==========================================
+ Hits 12222 12224 +2
- Misses 1170 1177 +7
|
5 tasks
juanbono
reviewed
Jul 31, 2023
| ContractClass::from_path(ERC20_CONTRACT_PATH).unwrap() | ||
| ); | ||
|
|
||
| // assert_eq!( |
There was a problem hiding this comment.
we can remove this comment right?
juanbono
approved these changes
Jul 31, 2023
MegaRedHand
approved these changes
Jul 31, 2023
| .get_contract_class(&felt_to_hash(&TEST_ERC20_CONTRACT_CLASS_HASH)) | ||
| .unwrap() | ||
| .try_into() | ||
| .unwrap(); | ||
| assert_eq!( |
There was a problem hiding this comment.
This is due to the Program comparison bug, right? I think we should comment it like the rest.
There was a problem hiding this comment.
Bono just asked me to remove it hahaha
There was a problem hiding this comment.
Ohh in that case we need to add a comment detailing why it is commented and what we need to do to uncomment it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
cairo-lang-*dependencies to2.1.0-rc2.Checklist