This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
refactor: use retain for error messages #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oppen
force-pushed
the
refactor/retain_error_msgs
branch
from
5a57aba to
f682898
Compare
juanbono
approved these changes
Aug 1, 2023
Codecov Report
@@ Coverage Diff @@
## main #872 +/- ##
==========================================
- Coverage 91.21% 91.21% -0.01%
==========================================
Files 54 54
Lines 13402 13400 -2
==========================================
- Hits 12225 12223 -2
Misses 1177 1177
|
xqft
approved these changes
Aug 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies a little bit the extraction of error messages in
to_cairo_runner_program.It saves a potentially big allocation in the process, but performance changes are likely negligible.
Checklist