Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Conversation

xqft
Copy link
Contributor

@xqft xqft commented Aug 9, 2023

Finish implementing revert logic for all txs in the case of actual_fee > max_fee

Description

Part of #862

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

Codecov Report

Merging #911 (5e9d38c) into charge_max_fee (acc0584) will decrease coverage by 0.04%.
The diff coverage is 62.50%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           charge_max_fee     #911      +/-   ##
==================================================
- Coverage           91.12%   91.08%   -0.04%     
==================================================
  Files                  54       54              
  Lines               13515    13529      +14     
==================================================
+ Hits                12315    12323       +8     
- Misses               1200     1206       +6     
Files Changed Coverage Δ
src/transaction/declare.rs 92.79% <62.50%> (-0.71%) ⬇️

@xqft
Copy link
Contributor Author

xqft commented Aug 31, 2023

Closed in favor of #917

@xqft xqft closed this Aug 31, 2023
@juanbono juanbono deleted the finish_implementing_revert branch October 24, 2023 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants