feat(eigen-client-extra-features): Replace third party dependant tests with mock tests #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore test Co-authored-by: Gianbelinche <39842759+gianbelinche@users.noreply.github.com>
gianbelinche
approved these changes
Nov 26, 2024
Co-authored-by: Gianbelinche <39842759+gianbelinche@users.noreply.github.com>
juanbono
reviewed
Nov 27, 2024
| @@ -291,6 +300,7 @@ mod tests { | |||
| assert_eq!(retrieved_data.unwrap(), data); | |||
| } | |||
|
|
|||
| #[ignore = "remote dependency"] | |||
There was a problem hiding this comment.
replace it with something more descriptive like:
"Depends on external RPC node"
juanbono
approved these changes
Nov 27, 2024
gianbelinche
merged commit 75090b6
into
eigen-client-extra-features
4 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
zksync_da_clientsto prevent a CI failure in case of third party issues (no connection to rpc used in tests)MockVerifierClientwhen running on the CI.cargo test -p zksync_da_clients -- --ignoredWhy ❔
Prevent CI running longer that it should, or even failing in case a third party service is not available.
Checklist
zkstack dev fmtandzkstack dev lint.