Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eigen-client-extra-features): Remove steps to run from integration docs #360

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

gianbelinche
Copy link

What ❔

This PR removes the steps to run from the integration docs.
Those are now on the zksync docs: matter-labs/zksync-docs#271

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@gianbelinche gianbelinche changed the title Remove steps to run from integration docs feat(eigen-client-extra-features): Remove steps to run from integration docs Nov 26, 2024
@@ -0,0 +1,13 @@
# EigenDA Client

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this file to README.md

Copy link

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase the added paragraph a bit. It assumes a lot from the reader.

@juanbono
Copy link

juanbono commented Nov 27, 2024

Scope
The scope of this first milestone is to spin up a local EigenDA dev environment, spin up a local zksync-era dev
environment and integrate them. Instead of sending 4844 blobs, the zksync-era sends blobs to EigenDA. On L1, mock the
verification logic, such that blocks continue building. Increase the blob size from 4844 size to 2MiB blob. Deploy the
integration to Holesky testnet and provide scripts to setup a network using EigenDA as DA provider.

This should be more clear.
Rename the title to Status and make a list with the milestones. Add a couple of sentences explaining each milestone.

@gianbelinche
Copy link
Author

Scope
The scope of this first milestone is to spin up a local EigenDA dev environment, spin up a local zksync-era dev
environment and integrate them. Instead of sending 4844 blobs, the zksync-era sends blobs to EigenDA. On L1, mock the
verification logic, such that blocks continue building. Increase the blob size from 4844 size to 2MiB blob. Deploy the
integration to Holesky testnet and provide scripts to setup a network using EigenDA as DA provider.

This should be more clear. Rename the title to Status and make a list with the milestones. Add a couple of sentences explaining each milestone.

Done

@gianbelinche gianbelinche merged commit 7a61574 into eigen-client-extra-features Nov 28, 2024
15 of 19 checks passed
@gianbelinche gianbelinche deleted the eigen-client-docs-reorg branch November 28, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants