forked from matter-labs/zksync-era
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Native erc20 contract fixes #68
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan518munoz
changed the title
Native erc20 contract fixes
feat: Native erc20 contract fixes
Jan 25, 2024
Oppen
pushed a commit
that referenced
this pull request
Feb 9, 2024
jrchatruc
requested review from
ilitteri,
juanbono and
IAvecilla
as code owners
February 14, 2024 18:21
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Change contracts submodule to work with native token implementation alongside ETH
Things to test
(CLI) Check native token y ETH balances:
npm run dev -- wallet balance --chain=local-geth --address=0x52312AD6f01657413b2eaE9287f6B9ADaD93D5FE --erc20-address=0xD47a77a7A93c099a451a2c269ea5fB35238dC52c && npm run dev -- wallet balance --chain=local-geth --address=0x52312AD6f01657413b2eaE9287f6B9ADaD93D5FE
Expected output:
(CLI) Deposit native ERC20
Expected output:
... Deposit: From: 0x52312AD6f01657413b2eaE9287f6B9ADaD93D5FE (L1 Local) To: 0x25E62AdC9d1BA5541A30814fbd6cf5efd14C129e (Dockerized local node) Amount: 0.000001 lambdacoin Sending deposit transaction... NATIVE ERC20 VERSION Deposit sent: Transaction hash: 0xfoo Sender L1 balance after transaction: XXX lambdacoin
(CLI) Withdraw & withdraw finalize native token
Expected output:
... Withdraw: From: 0x52312AD6f01657413b2eaE9287f6B9ADaD93D5FE (Dockerized local node) To: 0x25E62AdC9d1BA5541A30814fbd6cf5efd14C129e (L1 Local) Amount: 0.000001 lambdacoin Sending withdraw transaction... Withdraw sent: Transaction hash: 0xb140c9d6c2002a9b9434653cf6dff7754e08f66a4d4708ab5c51b9b0c66c96c1 Sender L2 balance after transaction: XXX lambdacoin
then
witdraw finalize
:Expected output:
Checklist
zk fmt
andzk lint
.zk spellcheck
.