Fix some comments #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toni-calvin
approved these changes
Feb 5, 2024
ilitteri
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Fix eth_sender value * Restore original config file and omit commented values * Format
mationorato
pushed a commit
that referenced
this pull request
Feb 15, 2024
* abstract setup mode method * remove blank line * add config mode in all init methods * update log * Fix some comments (#99) * Fix eth_sender value * Restore original config file and omit commented values * Format * abstract methods and constants * remove async * remove unnecessary async * change constant value * add cosntant * fix: test new vars (#114) * Update new variables between modes * Format * Fix toml format * Fix remove line * fix bug where dev.env is not overwritten * Revert "fix bug where dev.env is not overwritten" This reverts commit 051f173. * fix bug in dev.env load * Fix updateConfigFile * Fix initialization * Remove repeated constant definitions * Remove internal enforced l1 gas price set --------- Co-authored-by: toni-calvin <antonio.calvin@lambdaclass.com> Co-authored-by: Jordi <146965181+jordibonet-lambdaclass@users.noreply.github.com> Co-authored-by: Jordi <jordi.bonet.valiente@lambdaclass.com> Co-authored-by: Joaquin Carletti <joaquin.carletti@lambdaclass.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.