Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

password_reset_done view has bad name #24

Closed
giginet opened this issue May 26, 2014 · 2 comments
Closed

password_reset_done view has bad name #24

giginet opened this issue May 26, 2014 · 2 comments

Comments

@giginet
Copy link
Collaborator

giginet commented May 26, 2014

Password reset done view is named auth_password_reset_done on urls.py.

https://github.com/lambdalisue/django-inspectional-registration/blob/master/src/registration/urls.py#L48

However, django seems to recommend to name password_reset_done.

https://github.com/django/django/blob/1.6.5/django/contrib/auth/views.py#L142

Therefore, we will cause following errors when users access to Password change view.

django.core.urlresolvers.NoReverseMatch: Reverse for 'password_reset_done' with arguments '()' and keyword arguments '{}' not found. 0 pattern(s) tried: []
lambdalisue added a commit that referenced this issue May 27, 2014
The previous version define views of django.auth with 'auth_' prefix.
This cause some issue on djago 1.6 thus I add three new options to
prevent auto defining the urls and regulating the url name

-   `REGISTRATION_DJANGO_AUTH_URLS_ENABLE`
    If it is `False`, views of django.auth are not defined with
    django-inspectional-permission. Users must define these view
    manually. (Default: `True`)
-   `REGISTRATION_DJANGO_AUTH_URL_NAME_PREFIX`
    It is used as a prefix string of django.auth views. Set this 'auth_'
    for backward compatibility. (Default: '')
-   `REGISTRATION_DJANGO_AUTH_URL_NAME_SUFFIX`
    It is used as a suffix string of django.auth views. Set this ''
    for backward compatibility. (Default: '')
@lambdalisue
Copy link
Owner

Fixed in 0.4.0

@lambdalisue
Copy link
Owner

It was not fixed actually

lambdalisue added a commit that referenced this issue May 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants