Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fnameescape args for ex action #472

Merged
merged 1 commit into from
May 25, 2023

Conversation

tomtomjhj
Copy link
Contributor

No description provided.

@lambdalisue
Copy link
Owner

Why?

@tomtomjhj
Copy link
Contributor Author

Path name may contain special chars like space, %, +, etc. They have special meaning in the context of many ex commands (e.g. % gets expanded). So we should fnameescape it to avoid such interpretation.

btw vim-vinegar's · does fnameescaping too.

@lambdalisue
Copy link
Owner

lambdalisue commented May 24, 2023

Okay, it sounds good. However, in that case, I think there are few cases where fnameescape is not used, so I would like to stop tricky use of v:count and add it as a separate action if there is a demand for it. So please remove the v:count related functionality and documentation and re-implement it in a simpler form. Of course this is a destructive change, but it is close to a bug fix, so it is good.

@lambdalisue lambdalisue added the bug Something isn't working label May 24, 2023
@tomtomjhj
Copy link
Contributor Author

fixed as suggested

@tomtomjhj tomtomjhj changed the title feat: fnameescape args for ex action fix: fnameescape args for ex action May 25, 2023
@lambdalisue lambdalisue merged commit f7f41b5 into lambdalisue:main May 25, 2023
@tomtomjhj tomtomjhj deleted the ex-fnameescape branch May 25, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants