perf: unused field __cache_children

[tomtomjhj]

Together with __owner, this led to O(n^2) space where n is the number of nodes in directory, and yet it was not used anywhere.

see #508

Summary by CodeRabbit

• New Features

  • Enhanced asynchronous handling of node states within the Fern plugin for improved performance.

• Bug Fixes

  • Resolved issues with promise handling in various functions, leading to more efficient state management.
  • Improved the logic for collapsing and expanding nodes to prevent duplication.

[coderabbitai]

Walkthrough

The changes in this pull request focus on modifying the fern#internal#node functions within the autoload/fern/internal/node.vim file. Key modifications include the removal of caching mechanisms for child nodes, restructuring of promise handling in several functions, and updates to the reload and reveal functions for improved efficiency. The expand_tree function has been adjusted to collapse nodes before expansion, ensuring no duplication occurs. Overall, the changes simplify the management of cached states and promises in the Fern plugin.

Changes

File	Change Summary
autoload/fern/internal/node.vim	- Modified children, collapse, expand_tree, parent, reload, and reveal functions.
	- Removed caching of children nodes and streamlined promise handling.
	- Updated expand_tree to collapse nodes before expanding to avoid duplication.
	- Enhanced efficiency in handling node states and promise resolutions.

Poem

In the forest where nodes do play,
A rabbit hops, brightening the day.
With promises clear and states so neat,
Fern's new dance is quite the treat!
No more clutter, just smooth delight,
As we leap through the code, oh what a sight! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 0ba3d6a and fa67e9a.

📒 Files selected for processing (1)

• autoload/fern/internal/node.vim (0 hunks)

💤 Files with no reviewable changes (1)

• autoload/fern/internal/node.vim

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lambdalisue]

@tomtomjhj I've fixed CI so please rebase it.

[lambdalisue]

📝

Usage of __cache_children was removed via #486

[lambdalisue]

LGTM